trufflesqueak icon indicating copy to clipboard operation
trufflesqueak copied to clipboard

PolyglotInspector can't inspect hidden elements of large Arrays

Open janehmueller opened this issue 3 years ago • 5 comments

Large arrays are shortened in the Inpsector so that the head and tail are displayed and the middle part of the array is hidden by an ellipsis. When clicking on that ellipsis, one can enter and index to inspect. This works with the base Inspector, but with the PolyglotInspector, the element is not found.

image image

janehmueller avatar May 10 '21 15:05 janehmueller

Thanks! I've asked @LinqLover to take a look at this.

fniephaus avatar May 13 '21 11:05 fniephaus

I just proposed a fix for Squeak Trunk, could you please confirm that it resolves the issue for you? :-)

[squeak-dev] Changeset: fix-generic-inspectOne-with-truncation.cs

The changeset will make its way into the Trunk as soon as someone approves and merges it ...

LinqLover avatar May 14 '21 14:05 LinqLover

Excellent, thanks @LinqLover! With the changeset, the polyglot inspector seems to work fine. Great!

fniephaus avatar May 14 '21 14:05 fniephaus

Great! Please feel free to merge the changeset into the Trunk if it looks good to you. :-)

LinqLover avatar May 14 '21 14:05 LinqLover

Let me leave this to @marceltaeumel. He might be the better reviewer as he's familiar with the code already.

fniephaus avatar May 14 '21 14:05 fniephaus