LayoutKit

LayoutKit copied to clipboard

Swift 4 Migration

1

jingwei-huang1

Clarity of viewReuseId

1

Currently, it's unclear from the docs what `viewReuseId` means. If it should be used to uniquely identify every single view, if it's useful in collection view cells, if it's useful...

dgattey

Updating coding style

1

Per LinkedIn and Apple's latest style guides, LayoutKit does not conform to either. `viewReuseId` -> `viewReuseID` for example, and all `k` prefixed constants shouldn't be `k` prefixed. There's a lot...

dgattey

Create list with limitations/constraints of LabelLayout

5

LabeLayout relies on `boundingRect` method which does not work in all cases and I think that it would be great from documentation perspective if have a list of all limitations/constraints...

plamenterziev

Does arrangement in ReloadableViewLayoutAdapter need replace every time?

3

https://github.com/linkedin/LayoutKit/blob/master/LayoutKit/Views/ReloadableViewLayoutAdapter.swift#L91-L93 Say I have a table view with 1000 items, then I insert 1 item in it, it will regenerate the whole arrangement... Could we just replace the updated items?

RoCry

Support Swift package manager

1

Documentation: https://swift.org/package-manager/ - [ ] Create Package.swift ``` swift import PackageDescription let package = Package( name: "LayoutKit" ) ``` - [ ] Move Library code to a `Sources/` folder? -...

nicksnyder

async makeViews method

2

When an arrangement's UIViews are expensive to create and configure, `makeViews` can take more time than is available between frames. Current idea is to add an `asyncMakeViews` method that would...

staguer

ReloadableViewLayoutAdapter could use a few additions: - Detecting Collection/TableView size and its changes and using that for computing cell layout arrangements. - Delegate for scroll notifications. - Delegate for cell...

staguer

Accessing subviews in LayoutKit-generated view

2

Hello, Is there a recommended way to get at subviews of a LayoutKit-generated view? I'm currently iterating through the subviews of a view using `viewReuseId`, but I've also considered capturing...

dkindler

Animation doesn't work well for adding & removing views

7

Though animation works nicely for reused views, newly-added or removed views don't get any good visual effects since their frames are either miscalculated (when added) or not even calculated (when...

inamiy