Sergey Fomin

Results 18 issues of Sergey Fomin

### Change Scope - Add `gNOI` grpc service identity to complement the existing list of configurable grpc services (gNMI, gRIBI, P4RT, and soon-to-be-merged gNSI). - This change is backward compatible.

non-breaking

https://github.com/openconfig/public/blob/f46ca2cc6a2e5832cb0bd03d30c78b735129063c/release/models/interfaces/openconfig-if-ethernet.yang#L368-L382 Currently, `enable-flow-control` leaf does not specify in which direction the config is applied (tx, rx, or both). It is common for implementations to support rx/tx granularity, e.g.: - Arista...

Stale

Since gnsi.certz is now available, I think gnoi.certificate https://github.com/openconfig/gnoi/blob/fe1ddb7e7c22ec48380380e3cea93429937410e0/cert/cert.proto#L21 can be deprecated/removed in the next release? cc @marcushines

Should `qualification_rate_bytes_per_second` calculation take into the account all traffic that is sent during the qualification phase, or be recalculated independently for each `min_sample_interval`? E.g. if the test duration is 30...

Today `FactoryReset` service uses `factory_os` flag in `StartRequest` message to initiate a "rollback" to the factory OS version. Is there a specific requirement for what should happen when this flag...

Currently `PacketGeneratorCapabilities` message does not explicitly define `max_bps` and `max_pps` fields usage. Are they supposed to indicate capabilities of a single ASIC? What if there are multiple ASICs with different...

RT-5.9 sets ipv6 RA mode explicitly together with the disabled flag: https://github.com/openconfig/featureprofiles/blob/c9114a6fde8b77390a1d0de521e2ce777d844d1e/feature/interface/ip/ipv6_ND/otg_tests/disable_ipv6_nd_ra_test/disable_ipv6_nd_ra_test.go#L113-L116 It doesn't seem like mode is applicable to this case, since the enum only covers cases where ipv6...

bug

(moving this conversation from #2953 ) In some tests, there's an unusual configuration performed on DUT only for 100G FR ports, e.g.: https://github.com/openconfig/featureprofiles/blob/91796ca845a55876969dec6e9a574c5cc0800738/feature/interface/aggregate/otg_tests/aggregate_all_not_viable_test/aggregate_all_not_forwarding_viable_test.go#L347-L351 It is unclear why is this required....

bug

[gnmi-1.18 readme](https://github.com/openconfig/featureprofiles/blob/afe4b12d8f80e5fb4c847a3d72a17217eb7468fa/feature/platform/fabric/otg_tests/sampled_backplane_capacity_counters_test/README.md) lists two test cases that ask to validate ON_CHANGE telemetry only: https://github.com/openconfig/featureprofiles/blob/afe4b12d8f80e5fb4c847a3d72a17217eb7468fa/feature/platform/fabric/otg_tests/sampled_backplane_capacity_counters_test/README.md?plain=1#L21-L25 https://github.com/openconfig/featureprofiles/blob/afe4b12d8f80e5fb4c847a3d72a17217eb7468fa/feature/platform/fabric/otg_tests/sampled_backplane_capacity_counters_test/README.md?plain=1#L39-L44 In the code, however, there's also a test that validates sampled telemetry as well: https://github.com/openconfig/featureprofiles/blob/afe4b12d8f80e5fb4c847a3d72a17217eb7468fa/feature/platform/fabric/otg_tests/sampled_backplane_capacity_counters_test/sampled_backplane_capacity_counters_test.go#L53...

bug

In a scenario where a client skips session parameters negotiation, and starts with a `ModifyRequest` with an `AFToperation` only, should the successful operation be acknowledged with a deprecated `OK` status...