Lily
Lily
This PR has some overlap with #4705 in the CalcDefence file.
Updated to work with #4673, but still has duplicated code from #4705.
No more duplicated code, ready to merge.
UUID: a9411cea-f29d-40a2-9497-afc809bbe52b Proof: #808
Currently cast while channeling does not apply the less damage on the gem to the triggered skill.
I can't find anything else obviously wrong, so tentative LGTM.
After further investigation, the new numbers look more correct to me than the old ones. Before we were flooring to two decimal points. Actual value 3.99854 for the multi became...
If it's supposed to round down instead of to nearest int, then we just need to change ModList and CalcOffence to floor instead of round.
The PR above floors the multipliers individually rather than at the end like we did before. The result is that the multiplier is 3.97 in the test PoB you gave...
The main usecase for burst damage is for frozen legion right now. It's a skill where it's completely feasible to do 30m damage towards pinnacle bosses in one go. It's...