LexManos

Results 183 comments of LexManos

Looks like it works for the most part, just needs to fixup the S2S tasks ``` 19:06:14  :forge:extractRangeMap 19:06:14  Error: LinkageError occurred while loading main class net.minecraftforge.srg2source.ConsoleTool 19:06:14  java.lang.UnsupportedClassVersionError: net/minecraftforge/srg2source/ConsoleTool...

Most people do not use stand alone javadoc, they use their IDE to navigate around the source and read the docs it displays. So ya, some of the javadocs in...

What is the use of FloatValue vs DoubleValue? Also MapValue isn't used, and has issues with toml style layout. What are you wanting to use that for? All the other...

Throw some bin compat bouncers with `@Deprecated(forRemoval = true, since = "1.20.4")` and pull. Few other notes, May be worth reformatting the event class to braces on same line like...

Yes doing so would allow it to be pulled in 1.20.4, however with 1.20.5 coming here soon it doesn't matter.

You're right that is a messed up patch, the isSameItemSameTags should be removed. As the shouldCaueBlockBreakReset is the replacement for that method.

It being enabled at runtime is an intended change. But it does seem I should re-work it to be a two phase system to be sure to not locate things...

Was simpler then I expected. And was just another random list of hardcoded things that I intend to cleanup at some point in the future.

Thats what the changelog says yes. https://maven.minecraftforge.net/net/minecraftforge/forge/1.20.4-49.0.50/forge-1.20.4-49.0.50-changelog.txt