Lewis J Ellis

Results 45 comments of Lewis J Ellis

Hey @britzl! I saw Defold on my twitter feed this morning (I think from gamejam with itch?) and thought "hmm, I met this guy at the Lua workshop, do I...

I would prefer to keep OpenResty as the first one listed, since it's by far the most heavily used.

I just [ran into this today](https://twitter.com/LewisJEllis/status/1556820470502023168). This: ```js local.on('error', next); ``` bit should not send the error to `next`. You can see here in the old raven-node library that I...

Where do you run into this error? Do you have a snippet I can run to reproduce it? We don't depend on/require `pg`, we just look to see if the...

Ah, okay, that makes sense. I didn't really think about webpack in the Node case, but there are some legitimate uses, so it would probably be better here to check...

Earlier investigation didn't get anywhere - it wasn't as easy to juke webpack as I thought it might be - but I took a deeper dive into this today and...

It's an issue with raven-node `require`ing `pg` to check if we should instrument it for autobreadcrumbs. If `pg` is not present, we don't load it, but webpack can't know that...

I realized thanks to @cveilleux's comment that, if we can get away with it, simply removing the pg autobreadcrumb instrumentation will help. Since a major version (2.0.0 ref #314) is...

That's kinda how it already works, but yea in general we want as much magic as possible for when we eventually enable autobreadcrumbs by default. Autobreadcrumbs are currently off-by-default with...

There's not a particularly good way to do this right now, but #180 is an older PR for roughly the change you're suggesting. The events emitted by Raven are going...