Vansh
Vansh
Hey, A lot of nesting and match statements can be reduced by using error propagation For example this: https://github.com/shubhexists/vault/blob/8249ae1e107da8db48b9f567058178f15fbd8b95/src/commands/commit.rs#L21-L25 here at line 22 could be rewritten as: ```rust let current_branch...
Hey, as `String` is just a wrapper around `Vec`, we can use `Vec` as the concrete type to keep things consistent. We could also define a custom type `type Binary...
Hello, can you please give me more details on this? Thanks.
@jolestar Apologies for the late response. I created a PR #3398, please let me know if these changes look good.
> Can you add a sample entry function in > > https://github.com/rooch-network/rooch/blob/02567e201e0b16f34d61b96ecb2f01c9b173b801/examples/entry_function_arguments/sources/entry_function.move > > and call the function in > > https://github.com/rooch-network/rooch/blob/cc642470c0a4f590ed6536896e1850ff159792b2/crates/testsuite/features/cmd.feature#L237-L268 I've made these changes. Do they look good...
Let me know if these changes look good. I'll add more changes afterwards.
@0x009922 Hey! Could you please clarify what you meant by moving `--profile` into `--cargo-args`? thanks!
> * Soft-deprecating the current `--profile` argument of `kagami wasm` Hey, Is this task only about warning for the argument? Also, I pulled the branch from #5449 for the purpose...
@0x009922 I created a PR. Please take a look when you have some time.
Hey, I’ve added the tests and logs you suggested, and also refactored some code to avoid unnecessary allocations. Does the change from`Profile` to `Option` inside Args::Build look good to you?...