Leon Timmermans

Results 377 comments of Leon Timmermans

This change would be easier to review if it was cut into smaller pieces, you're doing many different things here.

This seems to be caused by https://github.com/Perl/perl5/pull/22507: `!$p->depth==1`. I guess this is a true positive, but neither interpretation seems very logical to me. Needs a ticket for sure in `XML::Twig`.

> I'm puzzled by why you think we need a ticket in XML::Twig. It's [passing](http://fast-matrix.cpantesters.org/?dist=XML-Twig;perl=5.41.4;reports=1#sl=7,1) all its tests. Can you clarify? Thanks. The warning comes from XML::Twig. But DBD::XMLSimple is...

This is caused by the removal of smartmatch. The affected line is: ``` my $is_readme_needed = !('Build.PL' ~~ @exists_installers && $map->{'Build.PL'} =~ /create_readme/); ```

I don't think this should have been closed, the issue has not been resolved.

> I'm not sure this really needs a PPC. I'm pretty sure we would welcome the addition of this as a platform, assuming the changes for it were sensible. Yeah,...

Perl-Toolchain-Gang/ExtUtils-MakeMaker#473 should fix this

> Can't C level arg CLONE_PARAMS* params be smuggled somewhere inside the child my_perl struct instead? Less boiler plate, and CC type checking comes automatically vs a cargo cult copy...

> "Currently CLONE is called with no parameters" should be amended, but this also means modules that don't accept an additional parameter are Doing It Wrong™. (This wording has been...

> If my_perl or CV* data smuggling is not picked as the final solution. I'm not very invested in any particular solution, I'm mainly invested in solving the problem of...