Leon Timmermans
Leon Timmermans
> Also affected: TMM/HEAT-Crypto-0.07.tar.gz http://www.cpantesters.org/cpan/report/fbd71cd8-3c50-11ef-86c6-156034470c55 That just needs a single `SvTHINKFIRST` to be fixed.
> I tried modifying *S_get_key_buffer() to do SV_CHECK_THINKFIRST(var); immediately prior to the BYTE* buff = (BYTE*) SvPV(var, len); line. > > This looks to fix the 'decrypt shared' test failure....
> > > Also affected: TMM/HEAT-Crypto-0.07.tar.gz http://www.cpantesters.org/cpan/report/fbd71cd8-3c50-11ef-86c6-156034470c55 > > > > > > That just needs a single `SvTHINKFIRST` to be fixed. > > @Leont, could you open a bug...
> @haarg you mean to say that software can be changed after somebody merges it? my word! He means the PPC shouldn't mention an implementation detail like that, it should...
I like the way Book phrased it, it's clear and correct.
> PerlIO-via/via.xs: PROTOTYPES: ENABLE; That's a core module, so we might as well fix it immediately.
Where do those things come from? Are you assuming our `Configure` is `autoconf`? I don't think any of those environmental flags do anything, and half of those config variables don't...
It looks like the patch is essentially "treat clang as gcc", which sounds like a generally sensible approach.
What if we add a `$^P` flag for this?
I'm wondering if a `pthread_kill` based approach wouldn't be better.