Leon Rabinovich

Results 9 comments of Leon Rabinovich

This looks like a duplicate of https://github.com/mockk/mockk/issues/1035, for which a fix should be available in an upcoming mockk release

Our AGP version is 8.5.0 and our Jacoco version is 0.8.7

We bumped Jacoco to its latest version (0.8.12) but unfortunately it still looks like enabling instrumentation drops our coverage by over 10%

Thanks for finding that @romtsn! Just finished some testing with that workaround and the numbers definitely look a lot better. We're still losing about 3% in coverage in our `app`...

Only replaced the Kotlin classes as we're 100% Kotlin, unless that's a mistake and I should replace the Java ones as well? I will call out that the branch with...

Workaround was applied as the following in our custom Jacoco class: ```kotlin val buildDir = project.layout.buildDirectory.asFile.get().path val excludes = Action { exclude(ANDROID_COVERAGE_EXCLUSIONS) exclude(ANDROID_HILT_EXCLUSIONS) } val classesFileTree: ConfigurableFileTree = if (project.plugins.hasPlugin("com.android.application"))...

> Do you notice any patterns in those files that lose coverage? Unfortunately I can't say that I see any patterns in regards to what's losing coverage. The one thing...

Did some more exploration today and, for the sake of sanity, disable the Sentry instrumentation while keeping the fix in place. This has the following results: - 1,404,600 of 2,036,846...

Thanks for your help here @romtsn! Happy to confirm that I've gotten things to work by adding a few extra exclusions on top of the workaround above: - `**/databinding/*.class` -...