LeonOtis
LeonOtis
Thanks for the feedback. The new set of changes have the history arrays in the LM engine sized according to the number of samples on an MPI rank and different...
[example_input.zip](https://github.com/QMCPACK/qmcpack/files/9244172/example_input.zip) Sure, here are input files for a quick example with the carbon trimer. The actual optimization results won't be very meaningful with low sample numbers and filtering an already...
Added a small fix to the legacy driver to correct a problem @ye-luo noticed with PR #4075. At this point, what else is needed before this PR can be merged?...
@ye-luo Ok, I've opened PR #4161 for that small change.
I've now added a unit test for parameter filtration. Are there any other changes I should make before this PR can be merged? @ye-luo @markdewing
@ye-luo The hybrid method should work with the batched driver. I've now added a test for it on H4, similar to what I previously added for the legacy driver.
> > @ye-luo The hybrid method should work with the batched driver. I've now added a test for it on H4, similar to what I previously added for the legacy...
Thanks, Paul and Ye, for the comments. I'll break up the changes I made and try to have a PR for a first component pretty soon. I haven't gotten around...
> Could you describe more about what you found difficult in interfacing with the batched drivers? It would be helpful for us to know which areas need more documentation or...