LenkaNovak

Results 9 comments of LenkaNovak

Currently, to get the expected surface integrals, the following corrections needs to be applied, depending on whether the original field was center or face: ``` sum(ones(space_2d_from_3d) ./ Fields.dz_field(space_2d_from_3d) ) #...

@szy21 , do you mind if me move this to 1.2.6, since we already achieve 1.2.5 for AMIP? E.g. [here](https://buildkite.com/clima/climacoupler-longruns/builds/668#018f325b-a6d2-4c2d-b67f-1416484fda11)

Awesome, thanks! Cc'ing @juliasloan25

Looking at [build_history](https://buildkite.com/clima/climaatmos-ci/builds/18094), there is not a huge change in performance, so do you guys think this is ready to be merged as is? @glwagner to fix the regression errors,...

[here](https://github.com/CliMA/ClimaAtmos.jl/blob/826b85e97d2a84e1c69f2447c3d2c0ee48f8ef29/regression_tests/ref_counter.jl#L4) :)

@charleskawczynski @dennisYatunin does increasing the ref counter make sense here, or is the behavioral change worrying? 🤔

Thanks, @charleskawczynski , this sounds like a good way forward. @juliasloan25 has already done some machine precision tests of atmos states, and she's seen departures after the first timestep (https://github.com/CliMA/ClimaCoupler.jl/pull/614)....

This issue is more about how lhf and shf are stored in atmos cache. It would be nice to replace `set_dummy_surface_conditions` with a `set!` function that allows the user set...

> @LenkaNovak - is it ok with you to turn the bullet points here into separate issues? I can put my issue about adding mass water and energy checks for...