Christian Legnitto

I bet this was accidentally dropped in the conversion to the proc macro.

Happy to take a PR with a test!

Good question, we don't have good i18n infrastructure. Is there anything built-in with mdbook?

I am personally a big fan of immediate public disclosure / radical transparency (I used to manage security updates for macOS and Firefox FWIW) but we haven't had a discussion...

This is awesome, thanks! Is there any way to unit test the traces? This is simple but in the future we want to add spans and the like.

> > This is awesome, thanks! Is there any way to unit test the traces? This is simple but in the future we want to add spans and the like....

Would be sweet to integrate https://docs.rs/tracing-futures/0.2.4/tracing_futures/. Actually, looks like it may not be needed soon: https://github.com/tokio-rs/tracing/pull/808

Ah, it looks like the test harness will be usable soon: https://github.com/tokio-rs/tracing/pull/793

Note this can't land yet as it is pointing to a random git repo. Once the PR lands and a release is cut this can land.

If you'll see, the sync span macro doesn't create a block so it doesn't get dropped immediately. For the async case, it gets attached to a future and works fine....