Lee Newberg
Lee Newberg
Just force-pushed to rebase to current master.
From valgrind I am getting 4 defects; see below. However, looking within `memcheck_index.html` and the web pages it links to doesn't tell me anything that is meaningful to me. Help...
All 4 valgrind defects mentioned above are present on the master branch too ... apparently unrelated to this pull request. I will force-push again, to rebase this branch to the...
Asking github.com to search all projects of the InsightSoftwareConsortium repository finds calls to `UnRegister` outside of the ITK project only from: - [ITKTutorialExercises/Source/exercise35/VTKImageFromITKReader/vtkMFCView.h](https://github.com/InsightSoftwareConsortium/ITKTutorialExercises/blob/9047c3d51f62ce7c486f88810cf1e071a0922a4e/Source/exercise35/VTKImageFromITKReader/vtkMFCView.h) - [ITKTutorialExercises/Source/exercise35/VTKImageViewer/vtkMFCView.h](https://github.com/InsightSoftwareConsortium/ITKTutorialExercises/blob/9047c3d51f62ce7c486f88810cf1e071a0922a4e/Source/exercise35/VTKImageViewer/vtkMFCView.h) - [ITKPerformanceBenchmarking/src/PerformanceBenchmarkingInformation.cxx.in](https://github.com/InsightSoftwareConsortium/ITKPerformanceBenchmarking/blob/b5c073b1074e9f13e53ed955355845b263edfdb1/src/PerformanceBenchmarkingInformation.cxx.in) - [ITKTubeTK/src/Registration/itkRigidImageToImageRegistrationMethod.hxx](https://github.com/InsightSoftwareConsortium/ITKTubeTK/blob/9841c28c8287f04269ceecf3560f7659d77f9643/src/Registration/itkRigidImageToImageRegistrationMethod.hxx) -...
> Some of ITK's remotes are under https://github.com/KitwareMedical, so it may be worthwhile considering them. Thanks! Yes, work would need to be done there. Specifically, of the occurrences of `UnRegister()`...
A proposal: we could could change the code in KitwareMedical/ITKUltrasound from ```c++ static Pointer New(void) { Pointer smartPtr = ObjectFactory::Create(); if (smartPtr.GetPointer() == nullptr) { smartPtr = new Self; }...
With legacy-remove functionality ```c++ static Pointer New(void) { Pointer smartPtr = ObjectFactory::Create(); if (smartPtr.GetPointer() == nullptr) { smartPtr = new Self; } #if !defined(ITK_FUTURE_LEGACY_REMOVE) if (smartPtr->GetReferenceCount() > 1) { smartPtr->UnRegister();...
I find several places in ITK itself where we fail to use `UnRegister()` in the current implementation of a `New()` method, so these are objects that will not be subject...
Also, some objects in `Modules/ThirdParty/GDCM/src/gdcm/Source/` have a `New()` method without a call to `UnRegister()` and, if the present pull request is deferred, might need to be fixed -- it depends...
Given the various never deallocated objects identified in the code in these recent comments, this issue might more properly be labeled BUG than an ENH. Which way should we go?:...