Cristian Le

Results 1279 comments of Cristian Le

Yes, there are a lot of weird incompatibility issues in their build-system. I will report them later. For now, you can use the following as a reproducer ```dockerfile FROM fedora:latest...

I think maybe the `ARG` part is a red herring. For me it fails to invalidate regardless if I use the `ARG` or not

This sets a maximum (tested) cmake version policy. I.e. if you run with any CMake version less than the upper-bound, it will set all its policies to `NEW`. If you...

One recommendation is to move the tools to their own export target file and include those only if requested via `COMPONENTS`. That way the user project can know if the...

Could you share an example build? `CMAKE_CURRENT_SOURCE_DIR` should be implicitly included. It might be a CMake version issue or cmake_policy instead.

Ok I did some debugging. Try this CMakeLists.txt instead: ```cmake cmake_minimum_required(VERSION 3.25...3.30) project(Example) include(FetchContent) option(JSON_VALIDATOR_INSTALL "example: Override" ON) option(JSON_Install "example: Override" ON) FetchContent_Declare(JSON_SCHEMA_VALIDATOR GIT_REPOSITORY https://github.com/pboettch/json-schema-validator GIT_TAG 2.3.0 ) FetchContent_MakeAvailable(JSON_SCHEMA_VALIDATOR) add_library(example...

Can you assign a review for https://github.com/packit/tmt-plans/pull/23 also please? [here](https://artifacts.dev.testing-farm.io/478ce034-c79f-41c7-8577-1962e4607bbf/#work-rpmlintpa2rsrgw_plans-packit_ci-rpmlint) is a test example (ignore the other failing tests)