LearningGp

Results 55 comments of LearningGp

Could you please take a look at this issue and advise on the recommended Python version and its corresponding pip version?@kat-litinsky

We may need to discuss whether we should support having multiple exporters active at the same time. I'm not sure about your perspective on this.

> > We may need to discuss whether we should support having multiple exporters active at the same time. I'm not sure about your perspective on this. > > I...

metrics会存储在本地的metrics日志中,另外1.8.7+版本初步支持了Prometheus导出

> 这个能力应该是注册中心的功能,注册中心可以感知到节点是否还存活/健康,放在流控组件上并不太合适。 我理解这个能力其实可以看作是实例维度的熔断,以流量的情况来做为是否熔断的依据,类似于Istio中的outlierDetection。节点本身存活/健康不代表能为特定服务消费方正常提供服务(比如特定服务消费方和服务提供方间的网络存在波动)。

这部分代码看起来当初是 bydesign 的,不过从当前的需求出发,感觉为这个规则增加一个严格模式,在严格模式下没有设置 orgin 的客户端请求会被拒绝,默认模式下保持原有行为,这样会不会更合适一些,欢迎加入讨论或提交优化的 PR。 PS:我们考虑在 2.0 中和安全能力一起重构这部分功能。

Thank you for your submission! Before we can review the code, the CLA needs to be signed.

Due to this PR's inactivity and the unsigned CLA, we are temporarily closing it. Feel free to create a new PR if you still intend to contribute after addressing the...

我想再详细讨论下这个场景,超低频率的请求访问是用于判断是否应该关闭熔断还是说持续保持这种低频率访问,还是说构造一个多阈值多级别的熔断会更符合咱们的需求