LearningGp
LearningGp
我会尝试在近期修复这个问题
The CLA needs to be signed before the code is merged. :black_nib:
> Shall I change traget branch to 1.8？ I'm sorry to have shelved this PR for so long, please change the target branch to 1.8 if it is convenient.
The CLA needs to be signed before the code is merged. :black_nib:
The CLA needs to be signed before the code is merged. :black_nib:
IMO, CircuitBreaker does not need multiple buckets for pulsed traffic scenarios, reusing a single bucket is sufficient.
这看起来确实是个问题，但是要不要在运行时支持这种同名我觉得可能得再讨论下，因为这样做会引入一些不必要的额外的复杂度，但其实只要不重名就不会有问题，另外 Issue 中的这个插件看起来是个不错的解决方案
如果方便的话，麻烦在sentinel-demo-annotation-spring-aop模块中完善下Demo以体现新的特性
> 另外昨天还看了下 resilience4j 的做法。 https://github.com/resilience4j/resilience4j/blob/eeaf57a8217ded7fe14bad511454f263f9e6f06d/resilience4j-spring6/src/main/java/io/github/resilience4j/spring6/fallback/FallbackMethod.java#L85 他们的 `MethodMeta` 结构我觉得值得参考。（可以直接照抄😅） 感谢贡献🚀，欢迎后续进行进一步优化
我们修改了分支模型，麻烦把PR的目标替换为1.8