ModernRoboticsCpp icon indicating copy to clipboard operation
ModernRoboticsCpp copied to clipboard

Test file criterion wrong

Open guzhaoyuan opened this issue 5 years ago • 2 comments

In the test file, the test criterion is set to ASSERT_TRUE(M.isApprox(result, 4));

According to Eigen Doc, this means as long as the difference is smaller than 4 times of min(M, result), it will pass. This is wrong. If you change a little bit of force or matrix list, the test still pass.

Normally we should set the criterion to something like 1e-4.

guzhaoyuan avatar Mar 15 '19 02:03 guzhaoyuan

Did you mean MassMatrixTest?

Le0nX avatar Mar 15 '19 09:03 Le0nX

Every test criterion should be set corretly, not just MassMatrixTest. This means we should change all the test assert and there might be some test fail in the existing code.

guzhaoyuan avatar Mar 15 '19 18:03 guzhaoyuan