Laurent Goderre
Laurent Goderre
Small comments on the docs
@tmachyshyn I opened a PR to optimize the layers and the size a bit: https://github.com/espocrm/espocrm-docker/pull/42
@tmachyshyn I added some comments to the docs. Would be possible to address those and then squash the commits in both PRs?
Would you be able to squash down to 1 commit for each repo?
@chtomek the tag `mysql:8.1` is debian based
Oh yeah, my bad
I'm reading the docs and maybe committing our custom SQL snippets manually might be a non-invasive way of doing it. Let me test it out. https://dev.mysql.com/doc/refman/8.0/en/innodb-autocommit-commit-rollback.html
I think the tools we are using today really help in accomplishing this. By dockerizing our applications using official images we get the benefits of security scans for the underlying...
The wording for the peer review seems to harsh. The point of code review is to ensure code quality, not to lay blame for bugs.
Yeah, that makes sense.