Lattice-Automation
Adding some events and handler
Hello @jjti ,
I added some features to SeqViz to increase the ability to control events triggered from elements like bases, translations and annotations where you can pass onClick, onDoubleClick, onContextMenu and onHover, then you can check the type of element and do some action. I added some example how we can use these handlers. I also added onKeyPress event handler if developer wants to set some custom keyboard shortcuts. I think onHover event handler will help to display more details about elements. onContextMenu and onKeyPress will be useful to build SeqViz editor not only a viewer.
Please review my changes and give me your opinion. I am waiting to hear from you.
Thank you to consider my pull request. @Eng-Elias
I opened this pull request before about 2 years and asked for review but I didn't get any response, so I left it? @rtviii
Good point! I assumed they are waiting for conflict resolution with mainline. But these on hover etc events would be quite useful to have.
Good point! I assumed they are waiting for conflict resolution with mainline. But these on hover etc events would be quite useful to have.
I am sorry but when I opened the PR, I ensured that there was no conflict then asked for the review. Anyway, I can resolve the conflicts, if you want to merge this PR.
Likewise, sorry, i just saw this last week. It's a shame the authors missed this back when you contributed.
Likewise, sorry, i just saw this last week. It's a shame the authors missed this back when you contributed.
No problem, it is a small issue, let me know if you want anything from my side
Hi @Eng-Elias, @rtviii ,
Apologies for the long silence on this PR — it slipped through the cracks. Thanks a lot for contributing this feature!
If you’re still interested, could you please resolve the merge conflicts? Once that’s done, we’ll review it promptly and work on getting it merged.
Thanks!
Done, I resolved the conflicts and fixed the tests @guzmanvig @jjti @rtviii
I read your comments and I will work on them later because I am a little bit busy these days. I actually opened this PR before 2 years and I didn't review the code when I resolved the conflicts that is why I am surprised of most comments because if I worked on this issue now, I wouldn't do most of those mistakes.
I read your comments and I will work on them later because I am a little bit busy these days. I actually opened this PR before 2 years and I didn't review the code when I resolved the conflicts that is why I am surprised of most comments because if I worked on this issue now, I wouldn't do most of those mistakes.
Thanks @Eng-Elias! Just in cased you missed it, I emailed you (to the address in your Github profile) regarding your use case and other PRs you have open