seqviz icon indicating copy to clipboard operation
seqviz copied to clipboard

Overlapping restriction enzyme sites

Open nicolazilio opened this issue 3 years ago • 1 comments

Hi there,

I just wanted to let you know that when two restriction enzyme sites are very close to each other, the labels overlap. Would it be possible to shift one of the labels on a different "level" so that they don't overlap anymore?

Thank you!

Nicola

MicrosoftTeams-image (5)

nicolazilio avatar May 19 '21 13:05 nicolazilio

Yes this should be possible to fix. It's a bit tricky to get the text to not overlap, but definitely possible/should happen

jjti avatar Jun 16 '21 00:06 jjti

Hi! I was just wondering on the status of this issue? Is a fix in progress or its gotten stale?

sahasukanta avatar Jan 02 '23 09:01 sahasukanta

It's super stale @sahasukanta. Thank you for bumping/reminding me though. I'll try to get this done within the next month

jjti avatar Jan 02 '23 14:01 jjti

@sahasukanta can you check out the change in the latest patch and let me know what you think? https://github.com/Lattice-Automation/seqviz/releases/tag/3.7.4

It's not perfect or really that smart, it just moves the righter-most enzyme label to the right on overlap. It's not quite like the circular viewer where overlapping labels are grouped, and shown on hover. Also, if the righter-most label gets pushed off the screen to the right, it's removed.

On a more positive note, hovering a cut-site now highlights the recognition site + darkens the enzyme name which I hope improves the experience a bit.

Screen Shot 2023-01-07 at 1 41 46 PM

jjti avatar Jan 07 '23 18:01 jjti

@sahasukanta can you check out the change in the latest patch and let me know what you think? https://github.com/Lattice-Automation/seqviz/releases/tag/3.7.4

It's not perfect or really that smart, it just moves the righter-most enzyme label to the right on overlap. It's not quite like the circular viewer where overlapping labels are grouped, and shown on hover. Also, if the righter-most label gets pushed off the screen to the right, it's removed.

On a more positive note, hovering a cut-site now highlights the recognition site + darkens the enzyme name which I hope improves the experience a bit.

Screen Shot 2023-01-07 at 1 41 46 PM

@jjtimmons I just tried the new release and it looks like there is an issue with the name position relative to the actual site on the map. The name sometimes seems to be at the next site instead of on the site itself. But the highlight on hover is working great!

Screenshot (682) Screenshot (681) Screenshot (683)

sahasukanta avatar Jan 07 '23 20:01 sahasukanta

Hey @sahasukanta , thanks a ton for the quick test and feedback re: enzyme labels. I believe I fixed the issue in the latest patch, before/after screenshot included using your example: https://github.com/Lattice-Automation/seqviz/releases/tag/3.7.5

If you don't mind, please let me know how it works

jjti avatar Jan 08 '23 23:01 jjti

Hey @sahasukanta , thanks a ton for the quick test and feedback re: enzyme labels. I believe I fixed the issue in the latest patch, before/after screenshot included using your example: https://github.com/Lattice-Automation/seqviz/releases/tag/3.7.5

If you don't mind, please let me know how it works

Hi @jjtimmons . These changes look great! Thanks a lot for the quick fixes too :D

sahasukanta avatar Jan 10 '23 20:01 sahasukanta

Awesome and thanks @sahasukanta , closing now

jjti avatar Jan 10 '23 21:01 jjti