LamentXU
LamentXU
I am not very fond of fixing it since it is not an optimization (it might change the behaviour a lot) and will effect the backward compatibility here. And the...
LGTM, cc @gaogaotiantian
LGTM, would you like to open a PR to solve it? Or I think I can try to open one.
> @LamentXU123 "LGTM" means "Let's get this merged" which is usually only used when a PR has been submitted, reviewed, *and* accepted by a core developer (or "Looks good to...
Well @picnixz I think this may be more like a security issue, because no IPv6 addr will be blocked by `blocked_domains`. Every cookie are accessable to IPv6 hosts. No cookies...
And don't forget to open news on [blurb it](https://blurb-it.herokuapp.com/add_blurb)
Sorry for trying to merge the wrong branch. I'm fixing it. Done now, sorry for the noise.
> Please add a test for empty port (e.g. "acme.com:") and nonnumeric port. I suspect there is an unintentional behavior difference here. for empty port and nonnumeric port, the regex...
> You have removed wrong code. Oups, my bad.
~Since `request_port()` is not a public function, I think removing the case that would return `None` has little drawbacks, but I'm not quiet sure whether we should remain the debug...