Bastien Abadie

Results 93 comments of Bastien Abadie

As discussed today, we would expose either - the list of TSV files to `parse_tc_logs` so it can count their number of lines & publish that - directly count the...

Would you consider a patch from Teklia if we [apply the official migration guide](https://shapely.readthedocs.io/en/stable/migration.html) on your codebase ?

- we should check the age of the [build there](https://github.com/mozilla/libmozevent/blob/a41fad391146bbdc182b3bcc295353c30f76bfbc/libmozevent/mercurial.py#L443) as there are other stop conditions - the age is obtainable through `PhabricatorBuild.diff.[some path in JSON]`

Side note: we need this patch to test deployment of #2449 (if we need to get some downtime, it will spam with try pushes otherwise)

The usage of this patch in events gives [this Sentry issue](https://github.com/mozilla/code-review/pull/2548)

I made a cleaner version of build expiry check, adding a new state on the build, and custom error messages. These 2 PRs still require some unit tests

@Archaeopteryx could you review https://github.com/mozilla/libmozevent/pull/109 then we need to build a libmozevent release (should just be a tag push) and use it in #2550

We can revert https://github.com/mozilla/code-review/commit/81053bf1953ced537ce91739057d8f6835b9d86f now that you're implementing the same behaviour as on MC. @marco-c This way we won't have to maintain env variables. WDYT ?

@mlbonhomme will fix these 2 dependabot MRs to land libmozdata update