code-review icon indicating copy to clipboard operation
code-review copied to clipboard

code-review-bot is still sending a default `python-requests` User Agent

Open globau opened this issue 2 years ago • 2 comments

#1692 is marked as fixed, however we're still seeing python-requests user-agent requests from the bot.

Andi says this might be via the bot's usage of libmozdata.

I'd argue it's a bug that libmozdata doesn't require consumers to an application specific user-agent, but that's a different issue.

globau avatar May 03 '23 14:05 globau

#1698 updated libmozdata to the latest version, which contains https://github.com/mozilla/libmozdata/pull/219.

By default, libmozdata is using "libmozdata" as default user agent (https://github.com/mozilla/libmozdata/blob/aa80079c9a036531606942e175a25400fa69cfe3/libmozdata/connection.py#L57) for almost everything. I filed https://github.com/mozilla/libmozdata/issues/222 to enforce users of the lib setting the user agent. And I filed https://github.com/mozilla/libmozdata/issues/223 to use the user agent everywhere in libmozdata.

We can close this once those https://github.com/mozilla/libmozdata/issues/223 is fixed and we make a new release.

marco-c avatar May 03 '23 20:05 marco-c

https://github.com/mozilla/libmozdata/issues/223 was fixed, https://github.com/mozilla/code-review/pull/2394 and https://github.com/mozilla/code-review/pull/2395 will update libmozdata and mostly fix this. Only https://github.com/mozilla/code-review/issues/2391 will be left after that.

marco-c avatar Oct 02 '24 14:10 marco-c

@mlbonhomme will fix these 2 dependabot MRs to land libmozdata update

La0 avatar Oct 07 '24 07:10 La0

Fixed by 3d3e0424c9f3bf52d2b3dc640cf7f12183c13658 and 734bdaf0cf6f15f17c873d166a45e13499482269.

marco-c avatar Oct 09 '24 10:10 marco-c