Lew Rossman
Lew Rossman
The changes I made to the PR's original code reside in a branch off of the fork that @lepton1979 created (lepton1979/EPANET). It is named `dev_issue532`. I propose that we park...
Sounds promising. I'm in favor of anything that can make the CI process simpler and more transparent. Perhaps the next step is to extend the demo action to run one...
This is already implemented in [epanet-dev's Network class](https://github.com/OpenWaterAnalytics/epanet-dev/blob/master/src/Core/network.cpp) (although it hasn't made it into its API since the latter is still a mirror of the 2.x API). I guess what...
By "critical pressure" I assume you mean the pressure below which no demand can be delivered under a pressure driven analysis. Additional code would have to be written to allow...
@chocolate-771 the EPANET source code would have to be modified to allow `pmin `and `preq `to vary among particular nodes. You cannot do this using the current toolkit DLL (or...
A couple of things here. First, placing an emitter at a node with negative demand is kind of weird (so the node is expected to have both inflow and outflow...
I was partially successful in adapting the methods of [Todini (2011)](https://iwaponline.com/jh/article-abstract/13/2/167/31084/Extending-the-global-gradient-algorithm-to?redirectedFrom=fulltext) and [Avasani et al. (2012)](https://iwaponline.com/jh/article-abstract/14/4/960/3200/The-extension-of-EPANET-source-code-to-simulate?redirectedFrom=fulltext) for producing more stable tank dynamics with EPANET's hydraulic solver. I was able to...
@boinst could you be more specific on how you want to modify the CMake scripts and if that would change the existing build process described in BUILDING.md. Are you sure...
@boinst thanks for your response. I poked around the list of VCPKG packages some more and found that NGSPICE (an open source version of SPICE) was included. [SPICE ](https://en.wikipedia.org/wiki/SPICE) is...
@allenmlowe the loss coefficient is pegged to the PCV's fully open minor loss coefficient Ko. If no valve curve is specified then a default linear curve is used which results...