Lew Rossman
Lew Rossman
Thanks @eladsal for checking the Appveyor tests (which I failed to realize now get run whenever a new commit is pushed to the remote). My local testing was just looking...
@fmartine the issue is that the EPANET 2.2 solution to the Piller example is clearly wrong (the PSV is open even though its upstream pressure of 55 m is below...
It turns out that only an Active PSV needs to have its source code modified to preserve connectivity downstream of it. For an Active PRV, since its downstream node is...
As a part of PR #634 I modified the CI regression test protocol to address the concerns raised in this issue. That PR made a one-line addition for pressure dependent...
The CI regression test changes recommended here have been merged into the `dev `branch through PR #634. I will keep this issue open to make visible what's been done in...
I suggested that `OFFLINE `be used to describe a condition where the tank is neither filling nor emptying (i.e., when its `EN_DEMAND` value is 0). It might not be the...
In the interest of avoiding further delay in finishing release 2.2, PR #505 was updated to have the Status Report state when a tank begins overflowing (in addition to its...
Resolved in the sense that it remains a feature to consider adding in a future version of the Toolkit.
Another way to view the contradiction in @fmartine 's example is to compute the effective loss coefficient that the FCV has when it delivers 40 l/s in the EPANET solution....
I believe that for a TCV the "setting" loss coefficient is meant to override any minor loss coefficient that was specified, meaning that the latter is only used when the...