Lew Rossman

Results 124 comments of Lew Rossman

@eladsal the first two examples provide the Cv/Cvo curves directly (although the first one has the axes reversed). The third one is an example plotting the partially opened k-value directly...

@eladsal since fraction open is the independent variable I think it should be on the X-axis. To illustrate how a valve characteristic curve can be generated from a table of...

I agree that the proposed change makes logical sense, but there are two mitigating factors that need to be considered: 1. it will break backward compatibility 2. it will break...

@makusuko thanks for providing a use case for the PBV. However it appears that the fix you provided doesn't work when there is not enough head available to achieve the...

I agree that this issue (PBV generating head) should be moved to an issue thread since it is a real problem and a robust solution for it has still not...

I would begin by just adding a new integer property to the **Pump** object (the `Spump` struct in `types.h`) named `GroupCount` whose default value is 1. In the `[PUMPS]` section...

@lepton1979 recently submitted a pull request (#599 ) that adds the two pump enhancements mentioned in the comment above. The new `EN_GROUPCOUNT` pump parameter allows one to treat a group...

@samhatchett yes, I actually implemented your suggestion for parsing a control statement before writing my comment. It adds another member to the `Scontrol` struct, named `PumpGroup`, that indicates if the...

@eladsal basically yes. The API functions for simple controls use Setting as the only argument for the control action taken. There is no way to indicate that the control is...

Since none of the ideas for modifying the API functions for controls to accommodate pump groups seems to resonate with anyone (including myself), I propose that we drop the pump...