Leo Rudberg

Results 29 comments of Leo Rudberg

Very cool @caleuanhopkins! Nothing looks wrong with your code from my perspective. I just learned that the [GIF package](http://godoc.org/image/gif#GIF) exists. I assume it would be "easy" ( :crossed_fingers: ) to...

Yup, this really needs to pulled in! Was tearing my hair out until I realized this was the fix.

Hi Mike, thanks for your PR! We're considering creating a `cloud-build-notifiers-community` repo for community-maintained notifiers but we would like to see more interest and PRs (like this one) before doing...

You're welcome 😄 I totally agree - for silly reasons we don't include the trigger name in the Pub/Sub payload (or Build resource for that matter). Until we provide the...

Hi all! We on Cloud Build are aware of this need but want to have a standardized implementation for all notifiers, so I filed #95. We're currently waiting on our...

Thanks for the FR! We're planning on accounting for this in #95 using [HTTP Messages](https://developer.mozilla.org/en-US/docs/Web/HTTP/Messages). Would that solve your use case?

Hi all, we on the Cloud Build team are definitely aware of this FR and are working on short-term and long-term plans! Please stay tuned...

Sure, but I really do appreciate for your contribution 😄 Would using Golang templates satisfy your use case? Do you have any preference between that templating language and Mustache for...

Hi (Not) Noah, We are working on a public requirements doc for templating and bindings in #95 . If there's anything that you'd like beyond what's suggested there, please feel...

Hi Chao, Based on [the way we do auth now](https://github.com/GoogleCloudPlatform/cloud-build-notifiers/blob/e18059bc9a588b7cd7c01594459cae1311e6d44a/smtp/main.go#L152), can you modify your notifier config at all to use the SES strings? I'm not familiar with SES myself, but...