Luke Walsh

Results 157 comments of Luke Walsh

@veed76 - can you take a look at your code coverage as it has dropped a lot 80% down from 92.70%

Hi @enmaboya The one issue potentially I see is you are not loading AppBridge completely is "SPA mode" is enabled because of your conditional added in `default.blade.php` This would theoretically,...

Apologies, totally missed the import for app bridge!

This PR also makes it very React centric, when Laravel bundles with VueJS out the box. As Shopify does not have a "Vue-App-Bridge" package, is this PR maybe constricting users...

@osiset that makes sense - I think the solution would need to be a package like Shopify's react/appbridge package, not sure if one exists so someone would have to make...

@osiset looks good to me and I agree, I think the strings are more readable tbf and just and overall simpler implementation for the same end result.

It is currently not supported but an open PR is partly there if you wish to use it as a base but it is unsupported. https://github.com/osiset/laravel-shopify/pull/935

@osiset going to merge this one (later) in too for the upcoming release as php8.1 is being used more and more and this fix stops the billing route breaking as...

Decent solution provided so closing ticket.

@nam-co just add it to your migrations when you create the shop table, you can just add whatever id you want when you create the table. Then in your user...