smart-contracts

smart-contracts copied to clipboard

get rate should not revert. only return 0

ilanDoron

re write deployment verification code

1

current contract verification code is in file: readVerifyDeployment.js in web3deployment folder. https://github.com/KyberNetwork/smart-contracts/blob/master/web3deployment/readVerifyDeployment.js This file does many checks on our setup. most of those checks are already done in other places....

ilanDoron

enable to unlist permission less order book reserve when it has 0 rate (no orders)

1

currently lister can lisit any new token for a reserve. many reserves were listed but currently don't support any orders. should add an option for lister to unlist reserve that...

ilanDoron

Sanity rate contract should return 0 if rate was never set

1

In present implementation it might revert.

yaronvel

avoid srcAmount 0 on call to reserve.getConversionRate (handle for token to token trades)

1

When calling getConversionRate with srcAmount 0, some reserves revert. On simple trade (not token to token) getExpectedRate modifies srcAmount 0 to 1, to avoid divide by 0. Token to token...

ilanDoron

Current trade flow (assuming maxDestAmount is valid): 1. network query rate from reserve with src amount. rate result name _networkRate_ 3. _actualSrcAmount_ = destAmount / _networkRate_ 4. call reserve.trade with...

ilanDoron

currently a few reserves (uniswap, permission less, more...) if srcAmount is 0 it reverts (division by 0)

ilanDoron

For permission less tokens, Kyber has no control over the listed tokens. this enables any token to be listed. including scam tokens, and worse then that. tokens that attack kyber...

ilanDoron

bad function call in conversion rate (pricing)

2

in conversion rate. https://github.com/KyberNetwork/smart-contracts/blob/02094d33d8d552adf8b4e58fbf38a3aabf27d12d/contracts/ConversionRates.sol#L227 call to getTokenQty(token, rate, qty); rate and qty are swapped should be replaced by getTokenQty(token, qty, rate); thanks to @namnm1991 for finding this bug...

ilanDoron

avoid assigning to function parameters

1

Assigning to function parameters should be avoided. Two occurences of this can be found in KYBER.NETWORK, specifically in the ConversionRates contract: • In the recordImbalance function, the argument rateUpdateBlock is...

ilanDoron