Michael

Results 18 comments of Michael

hi @callebtc @gudnuf, please can take this cleanup issue ?

Hi @callebtc, hope you see this on time, so i started working on this issue, but I want to make sure I fully understand what’s expected before making changes I've...

@callebtc 😅, been trying to work on this for days, feel like i've finally removed the paid field from mintQuote, most of the tests are failing now, is this breaking...

> A question about NUT-17 that seems to be relevant for this test: > > Does NUT-17 allow duplication, i.e. a state message to be sent to the websocket even...

hi @callebtc @gudnuf I too hit the same flake while setting up a local dev environment. The test failed ~60 % of the time with assert 5 == 3 (or...

> hey, thank you for your PR. > > I'm not sure if this would work. If someone swaps a single proof, say 1024 sats, and we return 1023 sats,...

thanks once again @callebtc for catching this, i've now made the swap() method detect implicit fees when the sum of input proofs exceeds the sum of output amounts, and passes...

> LGTM but one outstanding question regarding the removed line `await self.load_keysets_from_db()` > > what's the justification for that? @callebtc I replaced "await self.load_keysets_from_db()" because we now build self.keysets inline...

> Hi @KvngMikey, sorry for getting back to you late. We have a crud called `update_keyset` that supports setting the `active` flag (latest main also can update the fee, worth...