Ivan Kochurkin

Results 260 comments of Ivan Kochurkin

> I like the idea of consolidating the visitor tests Visitors are only one example, but actually there are more runtime tests that should be consolidated if it's possible and...

> Actions are never executed in lexer before predicates if I remember. The rule has to match lexically and preds before it's committed to match THEN actions would exec I...

I've simplified code and added a new warning `PREDICATE_AT_THE_BEGINNING_OF_LEXER_RULE_DEGRADES_PERFORMANCE`, see #3633. Full test sample: ```g4 lexer grammar T; @members {int pCount = 0; int aCount = 0; boolean p(String s)...

Makes sense. Also I'd recommend using the following action and predicate to check how and when they are executed: ```g4 int pCount = 0; int aCount = 0; boolean p(String...

The first action in the lexer rule is executed after rule matching and after all predicates as we've discussed before. But the first predicate in the lexer rule is executed...

> too bad that the build system is all screwy. Even circleci is now apparently not running our jobs. github actions changed their API and @ericvergnaud had to rebuild things......

Maybe it makes sense to request for extended free plan since ANTLR is valuable free and open-source project.

It looks like it should be implemented on the ATN level, not on Grammar AST and it should be even more easily (I thought ANTLR changes the order of actions...

@adamhathcock when are you going to merge this PR? @codeFather2 could you resolve merge conflicts?