Ivan Kochurkin

Results 260 comments of Ivan Kochurkin

> Apparently, the problem with #564 is solved by migrating to Antlr4 grammar. Another thing to do I suppose. I'm also working on mentioned issue, actually I've already refactored code...

This errors are also actual for lexer rules as well. By the way, now we have `The following sets of rules are mutually left-recursive` for left recursive rules but not...

Not actual for now, should be closed.

Please elaborate

It looks like behavior of JavaScript runtime differs from other ones because some tests are failing. I'll investigate.

Definitely it was a bug in JavaScript runtime. I've fixed it by separated commit.

Now all tests are green, @parrt it's ready for review :) @mike-lischke maybe it is interesting for you as well.

> I only have a certain amount of time so I'm just trying to optimize. I consider this is a quite important optimization since it affect all generated parsers. Also,...

> Also I have seen a number of unused ATN states, but that might be caused by some optimization in the antlr4ts runtime. Just check the ATN for states that...

> Overall this seems fine and a good idea. However I am not sure if the closure algorithm relies on this implicitly in some way. At first glance it doesn't...