Alexandre Sollier

Results 22 comments of Alexandre Sollier

Hi! I'd like to tackle this issue. For this, do we need to move the logic of this script into [cluster-provision/gocli](https://github.com/kubevirt/kubevirtci/tree/main/cluster-provision/gocli)? /assign

Hey @alicefr, I just opened a PR for this issue: #1164 :) I tested this new CLI manually with the steps described in the [KUBEVIRTCI_LOCAL_TESTING.md](https://github.com/kubevirt/kubevirtci/blob/main/KUBEVIRTCI_LOCAL_TESTING.md) file and I got a...

That PR should be ready for merging if there are no more reviews btw @alicefr

> @Kuruyia thanks for the work! Can you implement a couple of unit tests for the functions? Hey, thanks for your review! I'll address your change requests and add the...

> /cc > > FWIW #1174 is about to merge and will need to be covered here. I wasn't aware of this PR prior to starting this work sorry otherwise...

Hey! Sorry for the delay, I just added the unit tests as you asked, and ported here the NUMA feature that was recently added to `vmcli.sh` as well. Here's what...

> Yes, I think we could replace the bash script in a second PR. For example, we might need to think also how to transition form it to the golang...

@alicefr I changed the tests to use Ginkgo instead, it is much cleaner now :) I also modified the Dockerfile to split it into two stages. The first stage is...

> This is looking great, some quick comments but this should be ready to come out of draft and possibly land shortly. > > Can you provide a [Makefile](https://github.com/kubevirt/kubevirtci/blob/4151e66316dfab1d8bf22f9c999c6620ddd09f7d/cluster-provision/gocli/Makefile) that...

> @Kuruyia please squash the commits that changes the vmcli into a single one, for example, the ones that inline the errors. I squashed all the commits for the vmcli...