Kui LIU

SOLR-12244: Change method names

2

The method seems to add "sliceName" to "shardNames", thus the method name "addShardNames" should be better "getShardNames" since "get" means getting something.

Replace the inefficient Double constructor with static Double.valueOf() method.

2

Using new Double(double) is guaranteed to always result in a new object whereas Double.valueOf(double) allows caching of values to be done by the compiler, class library, or JVM. Using of...

Consider returning a zero length array rather than null.

1

It is often a better design to return a length zero array rather than a null reference to indicate that there are no results (i.e., an empty list of results)....

Remove the useless condition "variablesToInclude.length > 1".

1

The condition "variablesToInclude.length > 1" has no effect on the current statement. This condition always produces the same result as the value of variablesToInclude.length was narrowed before. http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_CONDITION

Remove the redundant null check expression of a non-null value lastResult.

6

The expression "lastResult != null" is a redundant check of a known non-null value because lastResult is non-null. http://findbugs.sourceforge.net/bugDescriptions.html#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE

java.lang.NullPointerException at com.gzoltar.core.GZoltar.run(GZoltar.java:51)

20

I follow the command in [https://github.com/SpoonLabs/astor/blob/master/docs/getting-starting.md](url) . Here is my command: java -cp $(cat /tmp/astor-classpath.txt):target/classes fr.inria.main.evolution.AstorMain -mode jGenProg -srcjavafolder /src/java/ -srctestfolder /src/test/ -binjavafolder /target/classes/ -bintestfolder /target/test-classes/ -location /Users/kui.liu/eclipse-workspace/astor/examples/Math-issue-280/ -dependencies examples/Math-issue-280/lib...

Change the method name "convertOverflow" to "isOverflow".

Correct the wrong author.

2

Lingming Zhang is not the author of GenProg papers.

Change the method name 'listBundles' to 'logBundles'. The method is named "listBundles". "listBundles" seems that the method will return a list of bundles. Actually, this method adds the bundles into...