Kryonn

Results 10 comments of Kryonn

> Just to be sure: when implementing functions, there are a couple of extra things that need to be taken care of. This is documented here and may be of...

> @Kryonn do you still need help? I did run the tests on the latest version of this PR but do not get the errors you report above In the...

I finished the NOR function, it’s now working correctly and without any documentation issues. As for the NAND function, I tried to implement it, but I wasn’t able to fix...

> I have no objection to adding `nand` and `nor` functions to mathjs, but is there any motivation for writing new internal code as opposed to just implementing them internally...

I will do these tasks * [x] Add nor/nand to test/typescript-tests/testTypes.ts * [x] Add nor/nand to the list of named infix logical operators in the mathjs expression language, parallel to...

> Thanks for the further updates. I take it from your previous post that you plan to leave the matrix optimizations, and extending the plain number logical tests to nand,...

> That's fine, just looking for clarity. If you're able to handle the comments on what you've done so far, we should be able to get this PR merged before...

> @Kryonn did you see the last comment from Glen? Is it possible for you to have a last look into the tests? I'm still going to change things, I'm...

I’ve finished fixing the tests. The NAND–OR, NAND–AND, NAND–NOR, OR–NOR, and OR–AND tests are now actually verifying operator precedence (with the higher-precedence operator on the right). In addition, I added...

All right, you can fix whatever needs fixing without rushing. If you find anything I need to correct, just comment on this issue.