Kristoffer Carlsson

I think the Overrides.toml is pretty much deprecated. However, using preferences I think jlls already have support for this, see e.g. https://docs.binarybuilder.org/stable/jll/#Overriding-specific-products. I don't think bespoke code should be added...

Something like this perhaps (I haven't used it very much myself): ```julia-repl julia> using gmsh_jll julia> gmsh_jll.gmsh_path "/home/kc/.julia/artifacts/65888a08d8ab9e3bf5e28f26eabd2731f2a95ff3/bin/gmsh" julia> using Preferences julia> set_preferences!( "LocalPreferences.toml", "gmsh_jll", "libgmsh_path" => "/lib/x86_64-linux-gnu/libgmsh.so.4.8" ) #...

> that automatically looks for gmsh in the system (like the one I implemented)? To me, that feels like it will be annoying to get correct on all systems. For...

> And also test a custom installation in the CI tests. Could always be added, but in some sense we are not really testing anything Gmsh-specific (Gmsh only knows about...

https://github.com/KristofferC/PGFPlotsX.jl/blob/761d80be651827fc067feb47b4f9f7faef1d78e9/src/tikzdocument.jl#L224-L231 for the PGFPlotsX side of this story.

The current version seems ok to me at least. Does it still obey `--color=no`?

`copystring` sounds like a string is being copied which is confusing.

> This will make using IOBuffer for creating strings less efficient, That seems completely unacceptable? Isn't the whole reason not to make this slow pretty much the reason for the...

> he point is that with this change takestring!(iobuffer) will be as efficient as String(take!(iobuffer)) is now, while String(take!(iobuffer)) will have a copy. The whole reason we didn't do this...

This is the comment I was thinking about: https://github.com/JuliaLang/julia/issues/24388#issuecomment-341206183