Kristoffer Carlsson

Sure, I can look at fixing that up later.

How about turning of the GC scrubbing (via the `gctrial` and `gcsample` in https://github.com/JuliaCI/BenchmarkTools.jl/blob/master/doc/manual.md#benchmark-parameters)? We only use the minimum value anyway for all reports and analyses.

> and just do > > ```juliacmd = benchmarkconfig.juliacmd``` I think that is how it used to work https://github.com/JuliaCI/PkgBenchmark.jl/commit/4113fe220383a7a9a6252161979a80adc80495e2#diff-21450190f4a3f8e55d48c877d0c9aba737cc12fb8c74afaa3cd28f3283669682L244 but it was changed. cc @omus.

> Perhaps an empty string should return nothing rather than throwing an exception as it is not invalid JSON. What makes you say it is valid JSON? Also, returning `nothing`...

Maybe https://github.com/JuliaIO/JSON.jl/blob/1c24980c320842e17720c173be767c161f36feb9/src/Parser.jl#L108 needs an `eof` check.

How is this related to `JSON.jl`? ``` julia> body = "This is not JSON\n" "This is not JSON\n" julia> array = Vector{UInt8}(body); julia> String(array); julia> array UInt8[] ```

FWIW, unless you want to use the macro based API in PkgBenchmark, "hooking up PkgBenchmark" will actually just mean to define a benchmark suite from BenchmarkTools so there is no...

To me, giving a single file to extract makes the most sense. If you want to extract multiple files, you just write a loop over the (possibly filtered) files and...

No, there is no urgency. Trying this out a bit in Pkg, it allocates 40GB to read all files in the registry and most of the time is spent on...

This is what I came up with for use in Pkg: https://gist.github.com/KristofferC/b354b654e776f4910b03985830418723 Here is it in action in Pkg: https://github.com/JuliaLang/Pkg.jl/pull/2431/. Ended up not using anything from this PR.