Kristoffer Carlsson

Results 1609 comments of Kristoffer Carlsson

This is literally what I am seeing for Rust: ![image](https://user-images.githubusercontent.com/1282691/75097730-72fbda80-55ae-11ea-957e-22b76c66244e.png)

Yeah, I do. Maybe it double-dips as a privacy policy blocker...

Are things getting initialized correctly?

But the jacobian gets updated every iteration?

https://github.com/JuliaNLSolvers/NLsolve.jl/blob/master/src/newton.jl#L110

This doesn't seem safe in general? What if `x` goes out of scope before the `unsafe_wrap` Array.

I tried this on VGG19 from Metalhead and got ```jl julia> @time Metalhead.weights("vgg19.bson") 0.662478 seconds (1.65 M allocations: 631.681 MiB, 15.95% gc time) Dict{Symbol,Any} with 38 entries: Please submit a...

> Maybe it'd be better to implement a write that works with an reinterpret array efficiently. Yeah, probably. https://github.com/MikeInnes/BSON.jl/pull/46 is at least a lot better than what we have now.

Interestingly, just defining ```jl function reinterpret_(::Type{T}, x) where T reinterpret(T, x) end ``` I can load VGG19 pretty damn fast ```jl julia> @time Metalhead.weights("vgg19.bson") 0.269944 seconds (1.97 k allocations: 548.196...