Kristoffer Carlsson
Kristoffer Carlsson
I rewrote a lot of the implementation here because I realized (while being on the treadmill :running_man:) that it made a lot of sense to just directly "transpile" the julia...
I think I am fairly happy with this now. Maybe the number of tests is a bit excessive; I basically added a test as soon as I found something missing...
Bump, I've run this locally for a while and it works very nicely for me at least.
> Oh sorry I didn't realise the tests were embedded into src/bin/julialauncher.rs itself. Those should be put in tests folder instead. It does technically work, but all the other tests...
> These are integration tests though The integration test was put in `tests/channel_selection.rs`
> I still kinda feel like these guys should sit in the tests folder. If it was a few property tests that someone could read to help understand the code,...
Ok, I'll make them pub and move them.
> If this is the blessed way (which still seems a bit hacky), could it be backportable to 1.11.x? Yes, we should do that.
https://github.com/JuliaLang/julia/pull/54009 and https://github.com/JuliaLang/Pkg.jl/pull/3865 should be backported.
I think this is fixed (cf comment above this).