Kristoffer Carlsson comments

Results 1607 comments of


                                            Kristoffer Carlsson

Cannot dev private repos: libgit2 uses protocol phased out by Github today? (SHA-1)

Also, I just want to say that we backported the `JULIA_PKG_USE_CLI_GIT` to the next LTS (1.6.6) which should be out in a few days.

Cannot dev private repos: libgit2 uses protocol phased out by Github today? (SHA-1)

I think we can keep this open for some extra visibility.

Progress bar width limiting doesn't work for precompilation progress bar.

The workaround given in https://github.com/JuliaLang/julia/issues/42649#issue-1026435090 could be attempted.

Add function Pkg.create_sysimage(package_name="", test_script="", update=true)

This could be prototyped in a separate package.

Ensure `@stdlib` is on `LOAD_PATH` for `.pkg/` hooks

Why would they not be available during the tests? The package has those as dependencies and they should therefore be available in the test project?

Ensure `@stdlib` is on `LOAD_PATH` for `.pkg/` hooks

> we decided to just restrict the package hooks to only be able to load stdlibs. That feels kind of arbitrary since the set of stdlibs is changing (https://github.com/JuliaLang/julia/pull/45540). If...

`convert` method for `Any` is not ideal

After that `similar` is fixed, I would say that CategoricalArrays are not significantly worse in terms of invalidations than many other packages. So this is a great improvement.

`convert` method for `Any` is not ideal

Bump, any plans on fixing the `similar` method? It shows up as the highest invalidation source in many applications I look at.

`convert` method for `Any` is not ideal

Note that I meant `similar`: Here is one example from SnoopCompile: ``` inserting similar(::Type{T}, dims::Tuple{Vararg{Int64, N}} where N) where {U, T

TimerOutputs ruins our line numbers

Anyone that is good with macro that knows how to modify https://github.com/KristofferC/TimerOutputs.jl/blob/9c82a14a1a63ef76148226cb9ea8138efec777cc/src/TimerOutput.jl#L196-L198 to insert line numbers of the original function?