Kristoffer Carlsson

Results 1581 comments of Kristoffer Carlsson

I think this discussion is really in the weeds.. When using this to install "Julia package apps", this feature is basically just a convenient way for a user to run...

> Optional modifications are fine, I just need to be able to turn them off. The shims that start up the application (and do have to be in `PATH`) have...

This has some rudimentary docs and tests now. I'd prefer merging this soonish to get into 1.12 and the test coverage can be improved based on that.

Ok, let's get this in so people can try it out and find a bunch of issues. Will be the fastest way to make this solid I think.

https://github.com/JuliaLang/Pkg.jl/pull/4556 should fix this.

My goal is just to fix the cases where it is an issue. After https://github.com/JuliaLang/julia/pull/60104 I don't know more problematic cases. https://github.com/JuliaLang/juliaup/pull/1315 should also improve things.

I don't know why this was put on the milestone, it's been like this for years.

Maybe better MWE: ``` julia> @descend Main.Precompilation._precompilepkgs(::Vector{Base.PkgId}, ::Bool, ::Bool, ::Bool, ::Bool, ::Bool, ::Vector{Pair{Cmd, Base.CacheFlags}}, ::IOContext{IO}, ::Bool, ::Bool, ::Bool) ERROR: AssertionError: isdefined(cache[mi], :inferred) Stacktrace: [1] is_already_cached(interp::Cthulhu.CthulhuInterpreter, result::Compiler.InferenceResult) @ Compiler ./../usr/share/julia/Compiler/src/typeinfer.jl:728 [2]...

Which calls `get!(() -> 3, d, 2)` which calls into the `dict.jl` implementation. ``` julia> @which get!(() -> 3, d, 2) get!(default::Union{Function, Type}, h::Dict{K, V}, key::K) where {K, V} @...

> Remove the double hashing in the get! method. Double hashing occurs if the dict is concurrently mutated - instead, throw an exception since we don't support that. I don't...