Kristoffer Carlsson
Kristoffer Carlsson
This happens to many windows buildkite workers in the ecosystem (and for Julia itself).
I think it believes it is a package if it has a `name` entry in the Project file.
> ERROR: expected the file `src/Binbench.jl` to exist for package `Binbench` at `/home/jakni/Documents/binbench` To me, that is quite clear. And then you add a bad package file (no module) and...
Personally, I think all our `deepcopy`s are wrong. For example, looking at how a container in Base behaves: ``` julia> d1 = Dict(1 => b) Dict{Int64, Vector{Float64}} with 1 entry:...
Yes, I would say you want to copy the options and the elements but not recursively copy "user values".
I think the Z comes all the way from https://github.com/JuliaLang/TOML.jl/commit/02cf9e85f39a36045532271071fd88e0be2171c5#diff-daf635fc60966c7826dcb301089f0408e7834d17ce0ec46018ff674814ba6186R36.
> I am not a big fan of explicit returns: given that Julia just returns the last value of the block like any Lisp, I find it superfluous. I think...
One question is if we should pid lock during the whole Pkg operations (like https://github.com/JuliaLang/Pkg.jl/issues/2219#issuecomment-730599026 suggests) or just during the writing of the results. If we only lock the environment...
> What would be the benefits of locking writes only? I think the current way we write the toml file there is no benefit really, we won't get any "torn...
> When is the result of an add operation actually written? https://github.com/JuliaLang/Pkg.jl/blob/9c9e12f0369c90f41ef5a3a0b6e27ae6c042a90d/src/Operations.jl#L1959 so in the end, but before `build` and `precompile`.