Kristoffer Carlsson
Kristoffer Carlsson
I don't really understand your comment. The docs for `AbstractArray` says ``` AbstractArray{T,N} Supertype for N-dimensional arrays (or array-like types) with elements of type T ``` That doesn't seem to...
Yes, having the exponent as a type parameter seems like a good idea.
Requires.jl makes loading this package 20x slower (https://github.com/JuliaStats/Distances.jl/pull/123#issuecomment-466438344).
> but as you can see from it's Project.toml, it is very lightweight. Distances.jl is also very lightweight, for example ``` julia> @time using Distances 0.039016 seconds (32.86 k allocations:...
Isn't this just a Zygote bug?
> One of the big advantages of Tables.jl is that it's lightweight and generic, so adding a dependency on it doesn't cost much. ``` > @time using Distances 0.051232 seconds...
The code here is quite old (before juia ran anything on GPUs) and written using loops so it isn't really gpu friendly. You should be able to fairly easy write...
Distances uses the standard convention that the first argument is the one getting mutated. It doesn't feel worth changing this when it has been like this for so long.
This doesn't look like an improvement to me and doesn't look like standard usage of traits. Traits are typically used for small pieces of extra information that you want to...
How would the `euclidean` way work with distances that store data in internal fields? Andreas' way feels more natural where you create the type and call it.