Kristoffer Carlsson

Results 1628 comments of Kristoffer Carlsson

I guess you can get back the old behavior by using an `IdDict` instead of a `Dict`?

Let's run a PkgEval and merge if it comes back green.

The StrBase error should probably be looked at.

Yeah, it is a bug here somewhere. With this PR: ``` julia> "α"[2] '\xb1': Malformed UTF-8 (category Ma: Malformed, bad data) ``` It's pretty amazing there is no test for...

I removed the erroneous fast path. Now StrBase.jl passes.

@nanosoldier `runbenchmarks("string", vs = ":master")`

> I don't actually see why those methods should be getting slower all of them end up calling memcmp and none of the methods that were changed. I don't think...

> I believe that the cmp method just ends up calling memcmp and doesn't call any of the methods that were changed Why do you believe so? ``` julia> str...