Krishna Dubey

Results 23 comments of Krishna Dubey

@timosachsenberg i have been thinking that we could Modify MSExperiment::updateRanges() as `void MSExperiment::updateRanges() { // Clear existing ranges clearRanges(); // Initialize spectra ranges double min_mz_spectra = std::numeric_limits::max(); double max_mz_spectra =...

@timosachsenberg yes, at [ https://github.com/OpenMS/OpenMS/blob/develop/src/openms/include/OpenMS/KERNEL/MSExperiment.h#L44](url) we can add below code to query spectra/ chromatogram ranges `RangeManagerContainer getSpectraRange() const;` `RangeManagerContainer getChromatogramRange() const;` `const RangeManagerContainer& MSExperiment::getChromatogramRange() const` `{ return chromatogram_range_;` `}` `const...

@timosachsenberg I think we make vcpkg more organised by adding Windows-specific dependencies like- `{ "dependencies": [ { "name": "libcurl", "platform": "linux" }, { "name": "corefoundation", "platform": "osx" } ] }...

@timosachsenberg no, I didn't as making vcpkg more organised did not need that, but if in order to merge those change it requires that surely I will.

@haixuanTao could please clarify more, whether you are pointing out failing CI tests.

@Mati-ur-rehman-017 are you still working on this issue

@haixuanTao I have been thinking that after adding "experimental-inspect" to `cargo.toml` and removing `generate_stub.py` should I need to make changes in code of `binaries/cli/src/lib.rs`(or any other file). Please guide me!

@Shiv-aurora as I had edited only "Python Conversation" file rest 3 files you can work on

@haixuanTao please review https://github.com/dora-rs/dora-rs.github.io/pull/27 while running the dataflow using instructions in https://dora-rs.ai/docs/guides/getting-started/conversation_py I had been encountering issue-ImportError: cannot import name 'Node' from 'dora' ![Image](https://github.com/user-attachments/assets/70765a08-dd1f-47d9-9960-661763e3d409) This was because virtual enviroment was...