charts icon indicating copy to clipboard operation
charts copied to clipboard

Update quickstart example yaml

Open akoshok1 opened this issue 2 years ago • 4 comments

When trying https://raw.githubusercontent.com/Kong/charts/main/charts/kong/example-values/doc-examples/quickstart-enterprise-licensed-aio.yaml

We get: * admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClass.networking.k8s.io "kong" not found * admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClass.networking.k8s.io "kong" not found * admission webhook "vingress.elbv2.k8s.aws" denied the request: invalid ingress class: IngressClass.networking.k8s.io "kong" not found * This makes sense. We set ingressController.ingressClass to default, and not kong. And then in manager.ingressClassName portal.ingressClassName and portalapi.manager.ingressClassName we refer to kong, and not default.

May I suggest we: 1-alter ingressController.ingressClass to kong 2-For consistency, also set admin.ingressClassName to kong

akoshok1 avatar Nov 15 '23 18:11 akoshok1

The ingress classes becomes inconsistent after https://github.com/Kong/charts/commit/da4889ffde4792cb44ace9e81bfc525313c700c3. We should use the same ingress class: all use default (the original value) or all use kong.

randmonkey avatar Nov 15 '23 18:11 randmonkey

Perhaps kong is a better choice, as there is a good chance default may already be used in clusters we install to.

akoshok1 avatar Nov 15 '23 19:11 akoshok1

Per chat, @mheap said he wanted to review this guide overall as part of fixing this, so assigning to him.

rainest avatar Nov 16 '23 21:11 rainest

While at it, let us please remove the two hostport settings which cause issues in EKS w/ Fargate and we do not use in other examples.

akoshok1 avatar Nov 22 '23 15:11 akoshok1