Kolin Guo comments

Results 5 comments of


                                            Kolin Guo

Pull Access denied for orbslam

This is because you don't have ssh-keys generated locally inside install/. A way to fix it is to generate the ssh-keys while building the Docker image. Change the block of...

Creating planner without SRDF parameter causing crash in v0.1.1

Hi, thank you for using MPlib. I believe this issue is resolved in #70. As for the release timeline, I cannot promise an exact date for the next stable release...

Uninitialized dataclass fields should be initialized with given default instance value

Hi @brentyi, thanks for your quick fix! I can confirm that the issue is resolved in your PR #391. BTW, what's your take to add the fields with `init=False` and...

Uninitialized dataclass fields should be initialized with given default instance value

Making fields overridable in those cases would be fine. But it contradicts to the meaning of `init=False` IMHO. - `init=False` means the fields should not be initialized at instantiation (first-time...

Uninitialized dataclass fields should be initialized with given default instance value

If you want to provide user with more ways to customize `tyro`'s behavior, you could maybe add a conf flag for this. If the fiag (say, `tyro.conf.AllowInitFalseFields`) is specified, then...