Koepel
Koepel
I have read your notes, but if you want to make the code better, there are some issues with the usage of the Wire library. There is no need to...
In the file "MinipH.ino" in the loop(), there is a while-loop after the Wire.requestFrom(). That while-loop can be removed, there is nothing to wait for. The Wire.requestFrom() is a complete...
In the file "smartcitizen-kit-20/sam/src/SckAux.cpp", in the function `getReading()`, there is a line `if (auxWire.available()
In the functions readAccReg() and readMagReg(), there is a Wire.endTransmission() after the Wire.requestFrom(). That should not be there. The Wire.endTransmission() is only used when writing data. It is not a...
In the function readReg(), there is a Wire.endTransmission() after the Wire.requestFrom(). That should not be there. The Wire.endTransmission() is only used when writing data. In the function read(), there is...
In the files "LSM303.cpp" and "L3G.cpp" there is sometimes a Wire.endTransmission() after the Wire.requestFrom(). That Wire.endTransmission() can be removed, it should only be used when writing data. The waiting or...
A Wire.endTransmission is only needed when writing data, it should not be used with Wire.requestFrom(). There is no need for a timeout after Wire.requestFrom(). When the Wire.requestFrom() returns, the complete...
In the file BMP085.ino https://github.com/cedtat/GY-80-sensor-samples/tree/master/BMP085 there is three times a while-loop after Wire.requestFrom. Those while-loops can be removed. When the Wire.requestFrom returns, the I2C bus transaction has completely finished and...
Hi, I have made a quick and dirty test sketch to find the best voltage distance between the keys. It turns out that if the high-side resistors at the rows...
After the Wire.requestFrom() there is no need to wait for something and the timeout with millis() is not needed. When the Wire.requestFrom() returns, the I2C transaction has completely finished and...