Knovek
Knovek
Regarding dink plugin, we're not using it for a few reasons - want to have more control on which achievements get broadcasted - i can check the username and clan...
Hi, I’ve been looking more into Dink to understand its limitations compared to what I’m trying to achieve, so please correct me if I’ve misunderstood anything. For death notifications, Dink...
@Felanbird Thanks for sharing the link, I’ve reviewed both the JSON examples and the external plugin messaging documentation. From what I can see, while Dink does support structured webhook output...
> It's as @tylerwgrass said above, there's no reasonable restriction on this functionality that we can enforce because edge cases will always be abusable (e.g., if you disable wilderness, people...
@tylerwgrass @riktenx As discussed, I’ve removed the scouting functionality from the plugin. Please let me know if this resolves the concern or if any further changes are needed.
@Adam- Thanks for pointing this out. I’ve removed all direct uses of java.lang.reflect.* from the plugin and reviewed the codebase to ensure no reflection is being used. The only remaining...
Hello, is there anything else I need to modify?
> Don't use java HttpClient or HttpUrlConnection. `@Inject` runelite's OkHttpClient and use that. You are already doing that in some places but not in others such as in your panel....
> You never shut [this](https://github.com/Knovek/runelite-one-shot/blob/master/src/main/java/com/oneshot/OneShotPanel.java#L1544) down, the repeat task is persisting even when the plugin is turned off. I've added that task shutdown to the deinit() function which is called...